Hello

One mostly nitpick question:

+extern bool parallel_vacuum_failsafe_triggered(ParallelVacuumState *pvs);
 extern void parallel_vacuum_bulkdel_all_indexes(ParallelVacuumState *pvs,

parallel_vacuum_bulkdel_all_indexes now might return quietly and
process only part of the work. Previously it either errored out, or
completed everything. Wouldn't it be be better to give it a return
value callers can check? Existing functions, such as
lazy_vacuum_all_indexes already do this. In this case the current
patch seems to be safe because of the lazy_check_wraparound_failsafe
call, but returning the status (and handling it in vacuumlazy) seems
like a safer not heap specific API.


Reply via email to