On Wed, Oct 28, 2026 at 09:04:00AM -0700, Bharath Rupireddy wrote:
> Nice, this is better. I think this approach makes the
> define-index-before-set-valid injection point redundant. I haven't dug
> into it, but maybe reindex-conc-index-built and
> reindex-relation-concurrently-before-{swap, set-dead, drop} too, since
> they all seem to be before a wait for lockers or older snapshots.

If you think that we could remove some of the INJECTION_POINT() macros
without impacting the coverage of the tests, we could do so.

I'm not planning to bother about a couple of lines of code, FWIW, and
the cost of these is low.  And there is always the back-branch
consistency argument.  As a whole I'm fine with the state of HEAD and
the stable branches.
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to