Hi, While reviewing patches, I spotted that pgstat_execute_transactional_drops()’s third argument, “bool is_redo”, is unused.
I checked the file history. Looks like 8b1dccd3 introduced the function without a full implementation, then 5891c7a8 implemented the actual statistics deletion, but never used is_redo. There are only 4 call sites that pass either true or false, but the value has no effect, which may confuse code readers. So, I propose this trivial patch to remove the unused argument is_redo. I have run “make check-world” and it passed. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
v1-0001-Remove-unused-is_redo-argument-from-pgstat_execut.patch
Description: Binary data
