On Wed, 28 Oct 2026 at 20:24, vignesh C <[email protected]> wrote: > > Few comments: > 1. The README, the macro comment, the code comment and the commit > message say such a buffer "never has a full-page image taken". The > code is include_image = needs_backup, so an image is still taken when > needs_backup is true. For example, _hash_freeovflpage() registers the > write buffer with REGBUF_STANDARD | REGBUF_NO_CHANGE, without > REGBUF_NO_IMAGE, when the primary bucket page is the write page and no > tuples are moved onto it. After a checkpoint, that record carries an > ordinary FPI of the page. > + The REGBUF_NO_CHANGE flag indicates that the buffer is registered without > + being modified by this record, and possibly without an exclusive content > + lock (for example, to force a cleanup lock on the block during replay). > + Such a buffer never has a full-page image taken, not even when WAL > + consistency checking is enabled: its contents may change concurrently > > Is this ok, or should we mention like "no consistency-check image"
I noticed that the patch has been committed. I thought this comment might have been missed during the discussion, so here is a small follow-up patch to clarify the behavior and avoid confusion: "This does not affect full-page images used for torn-page protection." Regards, Vignesh
v1-0001-Clarify-full-page-image-behavior-of-REGBUF_NO_CHA.patch
Description: Binary data
