On 06.10.26 22:41, Tristan Partin wrote:
On Mon Oct 5, 2026 at 7:52 PM UTC, Peter Eisentraut wrote:
Ok, all the infrastructure is in place now. I'm working through the
attribute additions now.
One thing to think about is that adding these attributes to server
header files would also affect extensions. I think we might want to do
some research about that. Like, is the normal API to fill in the
structure yourself, or are there wrapper functions that are mandatory to
use? I'm going to park that for the moment and work through the
attribute additions in .c files first.
I have to think that extensions testing with
-fsanitize=bounds/_FORTIFY_SOURCE=3 is pretty rare. In any case, I did
some analysis (grepping and reading) on the list of structs exposed in
header files against 9 popular extensions (not in contrib), and I didn't
find any potential issues.
Ok, I studies this a bit, too, and I think it's ok. I have committed
the rest of this, and added a note in the commit message about this.
I added an annotation to SharedMaterialInfo, which was added to
executor/instrument_node.h concurrently and fit with the pattern of the
other changes.
I dropped the annotation for BackendParameters. The way this type is
used as a local variable seems kind of a weird fit for this attribute.
I'm not sure.
