On Wed, Sep 9, 2026 at 8:10 PM Lucas DRAESCHER <[email protected]> wrote: [..] > v4 addresses all these items. I have moved the CF entry to "Needs review".
Hi Lucas, patch LGTM: - the tests pass: PG_TEST_INITDB_EXTRA_OPTS="-c io_method=io_uring" meson test -C build - issue is not reproducible with the patch - code looks good As for backpatching, dunno: on one hand I was suspecting more people would be affected so far, but it seems to be rare? (judging from EDB's tickets and not many people in this thread). So for me, fixing this only in master would be good enough (or maybe not that many people are using PG18+io_uring and getting SIGSEGvs). Anyway, just some nano findings: a. elog(DEBUG1, "cleaning up %d io_uring processes", TotalProcs) we are not cleaning "io_uring processes", but "io_uring instances" b. Commit message could stress more that that it prevents io_uring fd leaks on restarts, that sooner or later may cause failure to self-heal sooner or later with symptomps like one of the following: FATAL: could not setup io_uring queue: Too many open files FATAL: could not setup io_uring queue: Cannot allocate memory Perhaps, just ammend a little, drop v5 here and set to Ready for Commiter and let's see what happens. -J.
