Re: multi-row INSERT broken with a sublink in a target column subscript

[shihao zhong]

Hi Amit,

The fix looks right to me. One small thing in the test. Both
subscripts evaluate to 1, so it only sets f2[1]. Maybe use
(1 IS NOT NULL)::int + 1 and add RETURNING f2, so the output
shows both elements:

  insert into inserttest (f2[(select 1)], f2[(1 IS NOT NULL)::int + 1])
    values (9,10), (11,12) returning f2;

Thanks,
Shihao