Hi Chao,

Thanks for working on this.

2 interesting points.

1. V2 also fixes the crash Gowdham reported [1]. The committed fix
got reverted recently [2].

2. A CHECK error after set_null names the nulled column instead of
the row.

  CREATE TABLE r3 (a int CHECK (a > 0), b int);
  COPY r3 FROM STDIN WITH (delimiter ',', on_error set_null);
  -1,bad

  Without v2  CONTEXT:  COPY r3, line 1, column b: "bad"
  With v2     CONTEXT:  COPY r3, line 1: "-1,bad"

[1]
https://postgr.es/m/[email protected]
[2] https://git.postgresql.org/pg/commitdiff/c07545dfe1a

Thanks,
Shihao

Reply via email to