Hi Ishjaap, I reviewed v1 on master with assertions enabled. All psql TAP tests pass.
Additional checks confirm that materialized views and leaf partitions remain offered, including with schema-qualified names, and that plain `CREATE INDEX` still offers partitioned tables. The new completion list aligns with the backend behaviour: leaf partitions support `CREATE INDEX CONCURRENTLY`, while `DefineIndex()` rejects it for partitioned parents [1]. As you noted, if the backend patch allowing `CREATE INDEX CONCURRENTLY` on partitioned tables is committed, this completion filter will need revisiting. I found no issues with the patch. Looks good to me. [1] https://github.com/postgres/postgres/blob/0607aa61090ac1b574f8bafe854c684195b31e16/src/backend/commands/indexcmds.c#L740-L753 Thanks, Sho -- ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝ *Sho Ito (Sean)* E-mail: [email protected] LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/ <https://www.linkedin.com/in/sho-ito-0628/>* GitHub: https://github.com/sean0628/ ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
