On Wed, Nov 11, 2026 at 7:53 AM João Rito <[email protected]> wrote: > Following Michael's request in January, I picked this one up since the > thread has been idle for a while. I rebased the work onto current master > and addressed the review comments Sawada-san posted on 2024-10-31.
Thanks for updating the patch! LGTM, except for one comment. > I kept the "Returns the last XID assigned by this function" comment on > consume_xids() and consume_xids_until(), as Fujii-san asked. If the transaction already has a top-level XID and the next XID is at least the target, consume_xids_until() returns that next XID without assigning it. So isn't it better to update the comment for consume_xids_until(), for example, as follows? /* * Advance XID allocation so that the next XID is at least the target. * This may consume XIDs beyond the target. * * Ensures that the current transaction has a top-level XID. * Returns the last XID assigned by this call, or the next XID observed * if no XID was assigned. */ Regards, -- Fujii Masao
