On Wed, Nov 11, 2026 at 11:56 PM Fujii Masao <[email protected]> wrote: > > On Wed, Nov 11, 2026 at 7:52 PM Chao Li <[email protected]> wrote: > > Which bypasses the operations for successful close(df->fd), is that > > intentional? > > Yes. Previously, if compression finalization or the final write failed, > the function returned -1 immediately, skipping rename, unlink, and > sync. So the patch just preserves that behavior while releasing > the resources.
The fix LGTM. I am also a bit curious why unlink is also skipped before though it is unrelated to the cur patch. -- Regards, Xuneng Zhou HighGo Software Co., Ltd.
