On 11/12/26 16:18, Kirill Reshke wrote: > On Thu, 12 Nov 2026 at 17:57, Tomas Vondra <[email protected]> wrote: >> >> On 11/12/26 11:28, Tomas Vondra wrote: >>> >>> ... >>> >>> I suppose an expression walker that does not descend into PlaceHolderVar >>> nodes (with phlevelsup = 0) would make this work correctly. >>> >> Here's v3 doing it that way. >> >> -- >> Tomas Vondra > > v3 looks totally fine for me, perf regressions from my report > eliminated - good. > There are maybe some more cases to recurce, but we shouldn't defer > this bugs fix commit because of this. LGTM >
True. I picked only a subset of nodes for v3, but I suspect it might be expanded to the same set of nodes as contain_nonstrict_functions_walker and check_functions_in_node. I don't know if all of them can appear in the kind of quals we're processing. This kind of clauses is not very common, so I was conservative. But it's not great to cause a regression either ... I have to think about it. regards -- Tomas Vondra
