On Wed, Nov 11, 2026 at 6:17 PM wenhui qiu <[email protected]> wrote: > Just a very minor thought on the implementation: while nullable_relids is > allocated in the planner context and will be reclaimed anyway, perhaps we > could consider adding a bms_free(nullable_relids) before exiting > remove_useless_groupby_columns(), just to stay consistent with how other > temporary bitmapsets are cleaned up in that function?
I disagree. This function doesn't free any of its other bitmapsets, so I'm not sure where you get that conclusion. Freeing just this one would look odd. Also, I don't see the point: this one small bitmapset has no real impact on memory usage, and it will be cleaned up along with the planner's memory context anyway. I've pushed 0001 as-is and back-patched it to v18. - Richard
