Hi all, On 17 Oct 2026, Raja Sai Pranav wrote: > Would it make sense to drop the slot when BASE_BACKUP fails, if this > run created it?
For a backpatch, I'd preserve the old behavior on a refused start: drop the permanent slot if this run successfully created it and BASE_BACKUP is rejected before returning the startpoint. The ownership flag should only be set after successful creation, so a failed --create-slot cannot cause an existing slot to be dropped. I'd keep later backup failures unchanged. Our test drops the permanent slot itself after success, so it does not cover this. The bogus-checksum case should check both the specific error and absence of the new slot. An existing slot should survive both a rejected backup and a failed --create-slot. Cleanup failure should not replace the original backup error. Nick, could we put the early-error cleanup and its tests in a separate patch in the same backpatch series? That would keep the early-slot change focused. Thank you! Best regards, Andrey Borodin.
