On Mon, Nov 16, 2026 at 9:50 AM Zhijie Hou <[email protected]> wrote: > > On Sat, Nov14, 2026 at 02:18 PM Masahiko Sawada wrote: > > On Fri, Nov 13, 2026 at 7:35 PM Amit Kapila <[email protected]> wrote: > > > > While I agree that retaining the previous reason doesn't make us > > persist the slot, I think it's safe only because the previous reason > > is never SS_SKIP_NONE for a temporary slot at that point. That's true > > today, but it depends on several things and it would be hard to modify > > these code correctly in the future. > > > > I think the root cause is that commit 788ec96d591 replaced > > found_consistent_snapshot with the check of slotsync_skip_reason, but > > they're not equivalent: found_consistent_snapshot is false unless the > > current cycle synced the slot and found a consistent snapshot, whereas > > slotsync_skip_reason is SS_SKIP_NONE unless the current cycle detected > > a reason to skip. So an alternative idea would be to bring back > > found_consistent_snapshot part from the commit. That way, the decision > > of persisting the slot doesn't depend on the skip_reasons at all. > > > > As for the reported reason, a temporary slot is the one we have not > > confirmed to reach a consistent point yet. So I think we can simply > > report no_consistent_snapshot for a temporary slot if the current > > cycle didn't find a consistent snapshot, without relying on what > > happened in the previous cycles. > > I think it would be unnecessary to reintroduce the > found_consistent_snapshot out-parameter. Because by definition, > slotsync_skip_reason is SS_SKIP_NONE (NULL in pg_replication_slots) only > when slot synchronization succeeds. Even before commit 788ec96d591 > (since commit e68b6adad9), resetting slotsync_skip_reason to > SS_SKIP_NONE on a no-op cycle for a temporary slot was already a bug, > because synchronization of that temporary slot had not succeeded yet. >
I agree that the bug is because we didn't maintain/update slotsync_skip_reason correctly and we anyway need to maintain that state to correctly display it in pg_replication_slots. Also, the slot already carries the information about consistent_snapshot. SS_SKIP_NO_CONSISTENT_SNAPSHOT says the slot hasn't reached a consistent point, and it is visible in pg_replication_slots. A flag passed back to the caller to say the same thing would be a duplicate of that state. -- With Regards, Amit Kapila.
