On Sun Nov 15, 2026 at 10:44 PM -03, Chao Li wrote:
>> Just a note about the 0001 tests: they also pass on master without the
>> patch. On master an empty element is expanded to /extension, which
>> usually doesn't exist, so it's just skipped and the extension is still
>> found on the remaining directories. The difference is only visible if
>> /extension exists, which we can't create on a TAP test, so I don't think
>> that there is anything we can do here, but the tests are still useful to
>> prevent regressions.
>
> Yes, we cannot create an extension under /extension in the TAP tests.
> In v1, I added DEBUG3 messages to show the paths being searched, so
> the test could verify whether /extension was searched. I later removed
> those messages because they could expose system paths to
> non-superusers. Now the test only verifies that empty path elements do
> not prevent searching the remaining directories, so it also passes on
> master.
>

Yeah, I'm not sure if we can do better here. But I think that the test
is still worth.

> Thanks for preparing for the patch file for v18.
>

It seems to me that the patch don't have any more comments, so I'll mark
the CF entry as Ready for Committer. Additional comments are always
welcome.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com


Reply via email to