Hi Heikki,

Thanks for your patches.

0001 looks good to me.

For 0002

> if (s->blockState == TBLOCK_DEFAULT && s->state == TRANS_DEFAULT)
I think that changed the recovery conflict logic because of the following
code in
postgres.c

> case RECOVERY_CONFLICT_LOCK:
> case RECOVERY_CONFLICT_TABLESPACE:
> case RECOVERY_CONFLICT_SNAPSHOT:
> /*
> * If we aren't in a transaction any longer then ignore.
> */
> if (!IsTransactionOrTransactionBlock())
> return;
>
> report_recovery_conflict(reason);
> return;

And it will eventually become a FATAL which changes the current behavior.
Given
the window is quite small, maybe it is worth mentioning in the commit
message/comment?

Thanks,
Shihao

Reply via email to