Hi Yash,

Thank you for investigating the cfbot failures and providing the
expected-output update.

I incorporated your changes to
contrib/postgres_fdw/expected/postgres_fdw.out into the next version of
the patch. The failures were caused by the newly added CHECK constraint
expression changing the DETAIL text, while the postgres_fdw expected
output still contained the previous messages.

After merging the changes, I ran:

    make -C contrib/postgres_fdw check

and all postgres_fdw regression tests passed successfully. I will
include the updated expected output in the next patch version.

Thanks again for catching the missing regression test updates.

Regards,

Taiki Koshino<[email protected]>
SRA OSS K.K.
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/


________________________________
差出人: Yash Jadhav <[email protected]>
送信日時: 2026年11月15日 18:54
宛先: Koshino Taiki <[email protected]>
CC: PostgreSQL Hackers <[email protected]>; Yugo Nagata 
<[email protected]>
件名: Re: Proposal: Include CHECK constraint expression in violation error DETAIL

Hi,

cfbot is failing on v2 in the contrib/postgres_fdw regression test
(Linux Autoconf, Linux Meson, and others). Its expected output still
has the old DETAIL text for several check constraint violations.

I’ve attached a patch that updates
contrib/postgres_fdw/expected/postgres_fdw.out. I applied it on top of
v2, and make -C contrib/postgres_fdw check passes.

The attachment is named nocfbot, so cfbot doesn’t treat it as a
replacement for the patch set. You can apply the change into your next
version.

Regards,
Yash

Attachment: v3-0001-Report-CHECK-expression-in-constraint-violation-d.patch
Description: v3-0001-Report-CHECK-expression-in-constraint-violation-d.patch

Reply via email to