Hi Bharath,

On Thu, Nov 12, 2026 at 2:28 AM Bharath Rupireddy
<[email protected]> wrote:
>
> Hi,
>
> On Thu, Nov 5, 2026 at 11:04 PM Ashutosh Sharma <[email protected]> wrote:
> >
> > I have addressed comments 4 and 5 in the attached v5 patch.
>
> Thanks for updating the patch.
>
> > To summarize, v5 adds these:
> >
> > 1) Reports accumulated prefetch statistics at the end of recovery,
> > regardless of whether prefetching is enabled at that point, and
> > includes the current recovery_prefetch setting.
> >
> > 2) Adds regression tests covering zero counters and statistics
> > retained after disabling prefetching.
>
> A TAP test is an overkill here. The code is already covered in the
> recovery tests [1].
>
> > 3) Renames the function to XLogPrefetchLogStatsOnRecoveryEnd() to make
> > its intended use explicit.
> >
> > Please take a look and let me know for any other comments.
>
> I don't think we need to report whether recovery prefetch was on
> during the recovery in the log message (sorry for saying so upthread).
> BTW, even if we were to report it, RecoveryPrefetchEnabled() was the
> correct one to use. But I would drop it.
>
> Please have a look at the attached v6 with the above adjustments:
> moved the log message after the existing "last completed
> transaction..." message, reworded the commit message, and dropped the
> TAP test. I think it is RfC. Thoughts?
>

Thanks for sharing this. I don’t have any major comments, and the
changes look good to me. I’d be happy to wait and hear what others
think.

--
With Regards,
Ashutosh Sharma.


Reply via email to