On Wed, Nov 18, 2026 at 9:08 AM shveta malik <[email protected]> wrote:
>
> On Wed, Nov 18, 2026 at 6:42 AM Ajin Cherian <[email protected]> wrote:
> >
> > On Tue, Nov 17, 2026 at 9:03 PM shveta malik <[email protected]> wrote:
> > >
> > > Yes, the ERROR repeats until it is resolved, but that is the same
> > > behaviour as other tablesync errors (e.g. "table \"%s.%s\" not found
> > > on publisher"). The errors are also counted in
> > > pg_stat_subscription_stats, so users can monitor them.
> > >
> > > With the ERROR, the table stays in the 'd' (data sync) state, which is
> > > the correct state IMO. With a WARNING and skip, the table would
> > > wrongly be marked 'ready' instead, so its initial data would never be
> > > copied, even after a REFRESH PUBLICATION (provided the table is added
> > > back or the publication is created).
> > >
> > Hi Shveta,
> >
> > Just curious: with disable_on_error = true, this ERROR would disable
> > the whole subscription, and REFRESH PUBLICATION isn't allowed on a
> > disabled subscription. How would the user get out of that? If the user
> > re-enables the subscription, it's a race between the tablesync worker
> > hitting the error again and the user running REFRESH PUBLICATION.
>
> Good point Ajin. I did not think of it earlier, but on analysing it
> now, I think there is a way out without the race: since
> disable_on_error can be changed on a disabled sub, the user can
> temporarily set 'disable_on_error=false' on disabled sub, then ENABLE
> the sub, then REFRESH PUBLICATION, and then set disable_on_error back
> to true. I tested this with the patch, and it works.

I missed mentioning that alternatively, the table can be published
again on the publisher before re-enabling (if necessary).

> > I understand the same is true of other tablesync errors caused by
> > publisher-side changes (e.g. "table ... not found on publisher"), so
> > this isn't really related to this patch. But maybe we should document
> > somewhere how to get out of such situations.
> >
>
> As you said, this applies to all tablesync errors caused by
> publisher-side changes, so I think documenting it would be better done
> separately,e.g. as a note in the disable_on_error description?
> Thoughts? But if others feel that we can combine it in this patch, I
> am okay to do that.
>
> thanks
> Shveta


Reply via email to