Hi Joao, > While reading check_new_cluster_replication_slots() in pg_upgrade, I saw that > some errors say a setting is wrong but do not say what to change or in which > cluster. For example: > > "wal_level" must be "replica" or "logical" but is set to "minimal" > "max_replication_slots" (0) must be greater than or equal to the number of > logical replication slots (1) in the old cluster
Hmm. For me it's quite clear which value must be updated to what. In core code like CheckSubDeadTupleRetention(), the primary error message just says wal_level is sufficient; thus it made sense to print a HINT message. However, I don't think suggested HINT provides more information to user here. FYI, PostgreSQL community prefer to attach .patch files. See [1]. [1]: https://wiki.postgresql.org/wiki/Submitting_a_Patch Best regards, Hayato Kuroda FUJITSU LIMITED
