> On Nov 19, 2026, at 15:12, Jim Jones <[email protected]> wrote:
> 
> Hi Chao
> 
> On 19/11/2026 01:24, Chao Li wrote:
>> While debugging this patch, I noticed that the input isn has already been 
>> hyphenated, and ean2ISSN() is a local static function that is only called by 
>> ean2string(). Actually, your new logic of returning directly relies on isn 
>> being hyphenated. So I don't think we need to dehyphenate isn. Instead, we 
>> can just compare:
>> ```
>> if (strncmp(isn + 13, "00", 2) != 0)
>>   return;
>> ```
> 
> Good catch! dehyphenate is indeed superfluous here.
> v2 attached removes the function call and the digits buffer.
> 
> Thanks!
> 
> Best, Jim
> 
> <v2-0001-Fix-ISSN-output-truncation-when-the-issue-code-is.patch>

Thanks for updating the patch. V2 looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Reply via email to