On 19/11/2026 08:32, Chao Li wrote:
While reviewing another patch, I spotted a trivial optimization in
appendStringLiteralDQ().

Looking at the code:
```
        /*
         * Make sure we choose a delimiter which (without the trailing $) is not
         * present in the string being quoted. We don't check with the trailing 
$
         * because a string ending in $foo must not be quoted with $foo$.
         */
        while (strstr(str, delimBuf->data) != NULL)
        {
                appendPQExpBufferChar(delimBuf, suffixes[nextchar++]);
                nextchar %= sizeof(suffixes) - 1;
        }
```

The while loop always searches from the beginning of str. But
actually, a later search can just start from the previously returned
pointer. This function is currently only used by pg_dump. I don’t
expect a noticeable performance improvement in typical use, but it
seems to me to be a tiny but harmless optimization.

Makes sense. There's a similar loop in pg_get_functiondef(), too. I applied the same optimization there, and pushed.

- Heikki



Reply via email to