On 11/20/26 03:44, Fujii Masao wrote:
> On Fri, Nov 20, 2026 at 10:54 AM Tomas Vondra <[email protected]> wrote:
>> # Prefetching requires posix_fadvise(). Without it, the server rejects the
>> # non-zero maintenance_io_concurrency this test relies on.
>> if (!check_pg_config("#define HAVE_POSIX_FADVISE 1"))
>> {
>> plan skip_all => 'posix_fadvise() not supported by this platform';
>> }
>
> This check seems to skip the test on macOS because posix_fadvise() is not
> supported there. But, v18 and later have a platform-specific prefetch
> for macOS, so maintenance_io_concurrency = 1 can be set there.
>
> So, this check might be insufficient for macOS?
>
I'm planning to add the skip only on 15-17, so that on 18+ the test
keeps running everywhere. I believe that should still work even on
macos, but I've only tested it on Linux built without fadvise by:
./configure ac_cv_func_posix_fadvise=no
regards
--
Tomas Vondra