On Fri, Nov 20, 2026 at 8:05 PM Fujii Masao <[email protected]> wrote:
>
> On Fri, Nov 20, 2026 at 5:19 PM Xuneng Zhou <[email protected]> wrote:
> > +1 for backpatching and v5 LGTM.
>
> Thanks for the review! I've pushed the patch.
>
> > Do we need a regression test for this
> > issue in master? It seems that 24723e7cf39, b1f14c96720 and the
> > $subject all suffer from the extra header skipping of
> > pg_current_wal_insert_lsn()/GetXLogInsertRecPtr().
>
> So you're suggesting adding tests to verify that some operations such as
> WAIT FOR and pg_rewind handle the extra header situation correctly?

WAIT has the test in 24723e7cf39. I'm not sure whether it's
feasible/needed to add one for this issue. I'm thinking whether we
need to document/comment more about how
pg_current_wal_insert_lsn()/GetXLogInsertRecPtr() and its peer
GetXLogInsertEndRecPtr() handle the extra header situation . The
current abrevity of doc/comment seems to assume that users already
know the differences between these two and when to use each. But that
assumption seems unheld because we've seen several issues of misusing
them.

-- 
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.


Reply via email to