Hi Greg,

On Fri, Nov 20, 2026 at 4:13 PM Greg Burd <[email protected]> wrote:
> v20 attached, rebased onto 0cb41ee8070.

Thanks!  I ran another full pass over v20 on master under ASan + UBSan +
cassert, pgindent, 006_pg_dump_compress, 007_verify_toast_pointer, and
002_pg_upgrade.

All of the v19 items look cleanly resolved:
- populated vs. empty REFRESH MATERIALIZED VIEW behaves properly across
  repeated refresh + ANALYZE evolution cycles;
- the fipshash(), 006_pg_dump_compress.pl (gating on compile_option was
  definitely the right call for --without-zstd builds), verify_heapam
  truncated chunk-0 checks, and SGML updates all look good;
- and your plan on dictionary_evolution_max_retained (keeping it in 0005
  since 0004 and 0005 are meant to land together, and moving it into 0004
  only if a committer ever takes 0004 standalone) makes complete sense to
  me.

In this pass I also specifically tested partitioned tables and legacy
inheritance end-to-end (multi-level declarative partitioning, ATTACH /
DETACH [CONCURRENTLY] including dropped/reordered columns, cross-partition
UPDATE / MERGE / INSERT ... SELECT, trigger transition tables, partitioned
indexes, whole-tree REPACK / VACUUM FULL, pg_upgrade, and pgoutput logical
replication with publish_via_partition_root = true and REPLICA IDENTITY
FULL), checking on-disk headers via pageinspect.  Dictionaries stay
strictly attached to individual leaf partitions / tables throughout, with
zero cross-partition dictionary references.

At some future time it may make sense to re-visit the strict one
relation == one dictionary mapping and see if we can do better for
partitioned tables, where same dictionary could be used for many
partitions.

If nothing else, then maybe just copy the dictionary to the other
table when UPDATE moves a row there and the dictionary for some fields
in row does not exist.

(One strictly non-blocking committer-level trivia note in verify_heapam.c,
not worth a v21 on its own: at chunksize == 4 with method_bits == 3,
method_byte stays -1 so toast_compression_id_resolve() already reports
"has invalid compression method id 3 in its data" and returns before
reaching the `else if (method_bits == VARLENA_COMPRESS_METHOD_LONG)` arm,
while 5..8-byte truncated dictionary headers in 0004 hit the new
header_size check as intended -- so every truncated length is caught.)

I have no further findings; the whole v20 series (0001-0005) looks Ready
to me.

Cheers,
Hannu


Reply via email to