On 01/11/2018 18:54, Andres Freund wrote:> >> Also, from 691d79a which you just committed: >> + ereport(FATAL, >> + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), >> + errmsg("logical replication slots \"%s\" exists, but >> wal_level < logical", >> + NameStr(cp.slotdata.name)), >> I can see one grammar mistake here, as you refer to only one slot here. >> The error messages should read: >> "logical replication slot \"%s\" exists, but wal_level < logical" >> and: >> "physical replication slot \"%s\" exists, but wal_level < replica" > > Darnit. Fixed. Thanks. >
Since we are fixing this message, shouldn't the hint for logical slot say "Change wal_level to be logical or higher" rather than "replica or higher" :) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services