Hi, On 2018-11-07 08:21:09 +0100, Peter Eisentraut wrote: > On 05/11/2018 20:54, Andres Freund wrote: > > What mechanism are you referring to? Expected files and resultmap don't > > really fit that bill? > > We can add test files on the pg_regress command line based on makefile > conditionals.
But we don't... > >> If it gets to complicated to maintain, then we can also split files. > >> The collation tests are split like that. > > > >> What specific cases do you have in mind? > > > > I find both collation and xml good cases where it'd be good not to have > > an exhaustive alternative file. I mean, we currently don't even run the > > icu collation tests by default - and the above trick would make it > > fairly easy to automatically skip the test exactly when the database > > encoding makes that impractical? > > The issue with the collation tests is different. They need a database > with UTF8 encoding, which we cannot guarantee in the installcheck case. > Otherwise we could run them automatically with a makefile conditional. > (Early versions of the ICU patch did that, IIRC.) But isn't that precisely addressable with my proposed approach? I'll send a patch. Greetings, Andres Freund