Hi Tom,
On 11/7/18 9:30 AM, Tom Lane wrote:
I'm confused by this. Surely the pwrite-based code is writing exactly the
same data as before. Do we have to conclude that valgrind is complaining
about passing uninitialized data to pwrite() when it did not complain
about exactly the same thing for write()?
[ looks ... ] No, what we have to conclude is that the write-related
suppressions in src/tools/valgrind.supp need to be replaced or augmented
with pwrite-related ones.
The attached patch fixes this for me.
Unfortunately pwrite* doesn't work for the pwrite64(buf) line.
Best regards,
Jesper
diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp
index af03051260..2f3b602773 100644
--- a/src/tools/valgrind.supp
+++ b/src/tools/valgrind.supp
@@ -52,9 +52,10 @@
{
padding_XLogRecData_write
Memcheck:Param
- write(buf)
+ pwrite64(buf)
- ...
+ ...
+ fun:pwrite
fun:XLogWrite
}
