At Fri, 26 Oct 2018 14:13:51 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20181026.141351.09076928.horiguchi.kyot...@lab.ntt.co.jp> > Thank you for the fix. > > At Tue, 23 Oct 2018 17:26:37 +1300, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote in > <CAEepm=3BxOHw63Anwyx=pyy7Ju8cW6T0ZXNeKQS=wzp80hv...@mail.gmail.com> > > On Thu, Sep 6, 2018 at 9:57 PM Kyotaro HORIGUCHI > > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > > And don't we need a description about this restriction in the > > > function comment? > > > > Ok, added. > > Thank you. It looks good. > > > While rebasing, I also changed WL_EXIT_ON_PM_DEATH's means of exit > > from exit(1) to proc_exit(1). In master we're quite inconsistent > > about that as you can see from the lines removed by this patch, but > > the comments for proc_exit() seem to insist that it is the one true > > way out. Other than an elog(DEBUG3) message, the main difference > > between proc_exit() and direct exit() seems to be the PROFILE_PID_DIR > > stuff that changes directory on the way out the door for gprof users. > > It looks exactly like that for me, too. > > > It looks like per-pid gmon files could have been achieved by setting > > environment variables[1][2], but I guess there is some value in doing > > it the same way on every platform. > > > > [1] > > https://sourceware.org/git/?p=glibc.git;a=blob;f=gmon/gmon.c;hb=HEAD#l354 > > [2] https://github.com/freebsd/freebsd/blob/master/lib/libc/gmon/gmon.c#L154 > > Agreed. Anyway they don't allow the tweak for avworker. > > It seems fine for me. I'm going to mark this ReadyForCommitter > after a few days of waiting for anyone who has more > comments/opinions. > > https://commitfest.postgresql.org/20/1618/
Seen no objection nor further comments. I marked this as "Ready for Committer". regards. -- Kyotaro Horiguchi NTT Open Source Software Center
