Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> writes:
> * I think it's better to ignore the SIGPIPE failure in
> ClosePipeToProgram if we were in a COPY FROM PROGRAM that was allowed to
> terminate early and keep the behavior as-is otherwise. If we ignore
> that failure unconditionally in that function, eg, COPY TO PROGRAM would
> fail to get a (better) error message in CopySendEndOfRow or EndCopy when
> the invoked program was terminated on SIGPIPE, as discussed before [1].
> And to do so, I added a new argument to BeginCopyFrom to specify
> whether COPY FROM PROGRAM can terminate early or not.
If we do that, it makes this not back-patchable, I fear --- the fact
that file_fdw is calling BeginCopyFrom seems like sufficient evidence
that there might be third-party callers who would object to an API
break in minor releases. That seems unfortunate for a bug fix.
Are we sufficiently convinced that we must have the dont-allow-partial
option to not fix this in the back branches? I'm not.
regards, tom lane
