On Thu, Nov 29, 2018 at 09:09:48AM +0530, Amit Kapila wrote: > On Thu, Nov 29, 2018 at 8:46 AM Michael Paquier <mich...@paquier.xyz> wrote: >> With option 4 (as defined in [1]), the database ID or the user ID set to >> 0 means that we don't apply any filter on them, which is sensible. Now, >> we have query IDs which can be set to 0, like parseable utility >> statements. > > I think we ensure that queryId won't be 0 for utility statements.
Oh, pgss_store() makes sure to enforce the query ID which has been calculated in the post-analyze hook. That's a bit weird to be honest. >> When a query ID is set to 0, does this mean that all query >> IDs matching 0 are reset? Or does that mean that we don't filter out by >> query ID? >> > > It means the later one "We don't apply any filter for queryId.". Seems like it will be possible to live happily with option 4 then. -- Michael
signature.asc
Description: PGP signature
