> On Thu, Nov 8, 2018 at 4:03 AM Thomas Munro <thomas.mu...@enterprisedb.com> > wrote: > > On Tue, Nov 6, 2018 at 12:42 AM Kuntal Ghosh <kuntalghosh.2...@gmail.com> > wrote: > > On Thu, Nov 1, 2018 at 8:53 AM Thomas Munro > > <thomas.mu...@enterprisedb.com> wrote: > > > It passes make check on Unix and Windows, though currently it's > > > failing some of the TAP tests for reasons I'm looking into (possibly > > > due to bugs in the lower level patches, not sure). > > > > > I looked into the regression failures when the tap-tests are enabled. > > It seems that we're not estimating and allocating the shared memory > > for rollback-hash tables correctly. I've added a patch to fix the > > same. > > Thanks Kuntal.
Thanks for the patch, Unfortunately, cfbot complains about these patches and can't apply them for some reason, so I did this manually to check it out. All of them (including the fix from Kuntal) were applied without conflicts, but compilation stopped here undoinsert.c: In function ‘UndoRecordAllocateMulti’: undoinsert.c:547:18: error: ‘urec’ may be used uninitialized in this function [-Werror=maybe-uninitialized] urec->uur_info = 0; /* force recomputation of info bits */ ~~~~~~~~~~~~~~~^~~ Could you please post a fixed version of the patch?
