On 12/27/18 3:00 PM, John Naylor wrote: > On 12/27/18, Tom Lane <t...@sss.pgh.pa.us> wrote: >> diff --git a/src/tools/gen_keywords.pl b/src/tools/gen_keywords.pl >> + elsif ($arg =~ /^-o/) >> + { >> + $output_path = length($arg) > 2 ? substr($arg, 2) : shift @ARGV; >> + } >> >> My perl-fu is not great, but it looks like this will accept arguments >> like "-ofilename", which is a style I don't like at all. I'd rather >> either insist on the filename being separate or write the switch like >> "-o=filename". Also, project style when taking both forms is usually >> more like >> -o filename >> --offset=filename > This style was cargo-culted from the catalog scripts. I can settle on > just the first form if you like. >
I would rather we used the standard perl module Getopt::Long, as numerous programs we have already do. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services