On 02/01/2019 21:44, Tom Lane wrote: > Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: >> While we're considering the pg_regress output, what do you think about >> replacing the ======... separator with a standard diff separator like >> "diff %s %s %s\n". This would make the file behave more like a proper >> diff file, for use with other tools. And it shows the diff options >> used, for clarity. See attached patch. > > I'm confused by this patch. Doesn't moving the diff call like that > break the logic completely?
For clarification, I have attached a "before" and "after". -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff -u /Users/peter/devel/postgresql/postgresql/src/test/regress/expected/int4.out /Users/peter/devel/postgresql/postgresql/src/test/regress/results/int4.out --- /Users/peter/devel/postgresql/postgresql/src/test/regress/expected/int4.out 2018-12-07 15:10:58.000000000 +0100 +++ /Users/peter/devel/postgresql/postgresql/src/test/regress/results/int4.out 2019-01-03 11:49:53.000000000 +0100 @@ -1,4 +1,4 @@ --- +--x -- INT4 -- CREATE TABLE INT4_TBL(f1 int4); diff -u /Users/peter/devel/postgresql/postgresql/src/test/regress/expected/int8.out /Users/peter/devel/postgresql/postgresql/src/test/regress/results/int8.out --- /Users/peter/devel/postgresql/postgresql/src/test/regress/expected/int8.out 2018-12-07 15:10:58.000000000 +0100 +++ /Users/peter/devel/postgresql/postgresql/src/test/regress/results/int8.out 2019-01-03 11:49:53.000000000 +0100 @@ -1,4 +1,4 @@ --- +--x -- INT8 -- Test int8 64-bit integers. --
--- /Users/peter/devel/postgresql/postgresql/src/test/regress/expected/int4.out 2018-12-07 15:10:58.000000000 +0100 +++ /Users/peter/devel/postgresql/postgresql/src/test/regress/results/int4.out 2019-01-03 11:43:48.000000000 +0100 @@ -1,4 +1,4 @@ --- +--x -- INT4 -- CREATE TABLE INT4_TBL(f1 int4); ====================================================================== --- /Users/peter/devel/postgresql/postgresql/src/test/regress/expected/int8.out 2018-12-07 15:10:58.000000000 +0100 +++ /Users/peter/devel/postgresql/postgresql/src/test/regress/results/int8.out 2019-01-03 11:43:48.000000000 +0100 @@ -1,4 +1,4 @@ --- +--x -- INT8 -- Test int8 64-bit integers. -- ======================================================================
