On 03/01/2019 12:15, Nikolay Shaplov wrote: >> +1, let's keep it simple. I would just use "ctags/etags not found" >> as error message. > > Actually I was trying to say "Please install 'ctags' [utility] to run > make_ctags". But if all of you read it as "Please install 'ctags' [package] > to > run make_ctags", then it is really better to drop the advice. > > So I removed it. See the patch.
A few more comments. I don't know how portable command -v is. Some systems have a /bin/sh that is pre-POSIX. Same with $(...). If etags is not installed, the current script prints xargs: etags: No such file or directory I don't see the need to do more than that, especially if it makes the script twice as long. (Personally, I'd recommend removing make_etags altogether and using GNU Global for Emacs.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services