On 2019-Jan-03, Andres Freund wrote: > > Apart from this, we need to define different decode functions for > > zheap operations as the WAL data is different for heap and zheap, so > > same functions can't be used to decode. > > I'm very strongly opposed to that. We shouldn't have expose every > possible storage method to output plugins, that'll make extensibility > a farce. I think we'll either have to re-form a HeapTuple or decide > to bite the bullet and start exposing tuples via slots.
Hmm, without looking at the patches, I agree that the tuples should be given as slots to the logical decoding interface. I wonder if we need a further function in the TTS interface to help decoding, or is the "getattr" stuff sufficient. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
