> > On Tue, Jan 08, 2019 at 04:42:35PM +0900, Michael Paquier wrote: > >> I can see your point, though I would stick with > >> ERRCODE_WRONG_OBJECT_TYPE for consistency with the existing code and > >> because the code is intended to not work on anything else than plain > >> tables, at least now. > > > > Attached are my suggestions shaped as a patch. Thoughts? > > Thanks for updating the patch and sorry couldn't reply sooner. > > Your rewritten version is perhaps fine, although I remain a bit concerned > that some users might be puzzled when they see this error, that is, if > they interpret the message as "it's impossible to use a partitioned table > as logical replication target". > > >From [documentation]( https://www.postgresql.org/docs/current/logical-replication-restrictions.html ) : > Attempts to replicate tables other than base tables will result in an error.
That's basicaly what I had understood about logicial replication... Cheers, Lætitia -- Adoptez l'éco-attitude N'imprimez ce mail que si c'est vraiment nécessaire
