Hi, On 2019-01-07 17:03:20 +0530, Amit Khandekar wrote: > On Sat, 5 Jan 2019 at 02:09, Andres Freund <and...@anarazel.de> wrote: > > On 2019-01-03 13:40:42 -0500, Tom Lane wrote: > > > I noticed that this patch has broken restores of existing dump files: > > > > > > psql:testbed.public.backup:82: ERROR: unrecognized configuration > > > parameter "default_with_oids" > > > > > > Quite aside from the fact that this won't work if the user tries to > > > restore in single-transaction or no-error mode, this is really really > > > unhelpful because it's impossible to tell whether the error is > > > ignorable or not, except by digging through the dump file. > > > > > > What you should do is restore that GUC, but add a check-hook that throws > > > an error for an attempt to set it to "true". > > Attached is a patch that does this.
Thanks! I've pushed this, after some minor editorialization (hiding the GUC, shortened description, shortened error message). Regards, Andres
