On Tue, 15 Jan 2019 at 12:27, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Mon, Jan 14, 2019 at 2:07 PM Amit Khandekar <amitdkhan...@gmail.com> > > wrote: > > > > createPQExpBuffer() should be moved after the below statement, so that > > it does not leak memory > > Thanks for noticing, fixed.
Looks good. > > > So how about bumping up the archive version and doing these checks ? > > Yeah, you're right, I've added this check. Need to bump K_VERS_MINOR as well. On Mon, 14 Jan 2019 at 18:36, Amit Khandekar <amitdkhan...@gmail.com> wrote: > +static void _selectTableAccessMethod(ArchiveHandle *AH, const char > *tablespace); > tablespace => tableam This is yet to be addressed. -- Thanks, -Amit Khandekar EnterpriseDB Corporation The Postgres Database Company
