Hello David & Surafel,

About this v10:

Patch applies and compiles cleanly, local & global "make check" ok.

A few comments, possibly redundant with some already in the thread.

Out of abc-order rows-per-inserts option in getopt struct.

help string does not specify the expected argument.

I still think that the added rows_per_insert field is useless, ISTM That "int dump_inserts" can be reused, and you could also drop boolean got_rows_per_insert.

The feature is not tested anywhere. I still think that there should be a test on empty/small/larger-than-rows-per-insert tables, possibly added to existing TAP-tests.

--
Fabien.

Reply via email to