Hi Jesper, Thanks for updating your patches quickly.
>On 1/28/19 3:50 PM, Peter Eisentraut wrote: >>> Done, and v4 attached. >> >> I would drop the changes in pgupgrade.sgml. We don't need to explain >> what doesn't happen, when nobody before now ever thought that it would >> happen. >> >> Also, we don't need the versioning stuff. The new cluster in >> pg_upgrade is always of the current version, and we know what that one >> supports. >> >Done. I just checked the patch. As per advice, you removed the versioning and specified --jobs. The patch still applies, builds and passed the tests successfully. I'd argue though that it's helpful to find a short documentation to clarify that it's not pass down by to vacuumdb default. I think the initial doc change from the previous patch would be good. + machine. Note, that this option isn't passed to the + <application>vacuumdb</application> application by default. Just remove the comma symbol from "Note, that..." Regards, Kirk Jamison
