Amit Kapila <amit.kapil...@gmail.com> writes: > It seems you would also like to see this back-patched. I am not sure > if that is a good idea as there is some risk of breaking existing > usage. Tom, do you have any opinion on this patch? It seems to me > you were thinking to have a separate hook for partial paths, but the > patch has solved the problem by moving the hook location.
I was expecting Haas to take point on this, but since he doesn't seem to be doing so, I'll push it. I don't think there's any material risk of breaking things --- the only functionality lost is the ability to remove or modify baserel Gather paths, which I doubt anybody is interested in doing. Certainly that's way less useful than the ability to add partial paths and have them be included in Gather-building. In a green field I'd rather have had a separate hook for adding partial paths, but it's not clear that that really buys much of anything except logical cleanliness ... against which it adds cost since the using extension(s) have to figure out what's going on twice. Also this way does have the advantage that it retroactively fixes things for extensions that may be trying to make partial paths today. regards, tom lane