On Wed, Feb 13, 2019 at 12:42 PM Michael Paquier <mich...@paquier.xyz> wrote:
> On Tue, Feb 12, 2019 at 06:03:37PM +1100, Haribabu Kommi wrote: > > During the testing allow group access permissions on the standby database > > directory, one of my colleague found the issue, that pg_basebackup > > doesn't verify whether the existing data directory has the required > > permissions or not? This issue is not related allow group access > > permissions. This problem was present for a long time, (I think from > > the time the pg_basebackup was introduced). > > In which case this would cause the postmaster to fail to start. > Yes, the postmaster fails to start, but I feel if pg_basebackup takes care of correcting the file permissions automatically like initdb, that will be good. > > Attached patch fixes the problem similar like initdb by changing the > > permissions of the data > > directory to the required permissions. > > It looks right to me and takes care of the case where group access is > allowed. Still, we have not seen any complains about the current > behavior either and pg_basebackup is around for some time already, so > I would tend to not back-patch that. Any thoughts from others? > This should back-patch till 11 where the group access is introduced. Because of lack of complaints, I agree with you that there is no need of further back-patch. Regards, Haribabu Kommi Fujitsu Australia
