Hi Stephen,
On 2018-12-06 12:54:18 -0800, Paul Ramsey wrote: > On Sun, Dec 2, 2018 at 7:03 AM Rafia Sabih <rafia.sa...@enterprisedb.com> > wrote: > > > > The idea looks good and believing your performance evaluation it seems > > like a practical one too. > > Thank you kindly for the review! > > > A comment explaining how this check differs for is_slice case would be > helpful. > > Looks like PG indentation is not followed here for n. > > I have attached updated patches that add the comment and adhere to the Pg > variable declaration indentation styles, > ATB! > P You were mentioning committing this at the Brussels meeting... :) Greetings, Andres Freund
