On Mon, Feb 18, 2019 at 10:06 PM Jamison, Kirk <k.jami...@jp.fujitsu.com> wrote: > It sounds more logical to me if there is a parameter that switches on/off the > logging > similar to other postgres logs. I suggest trace_log as the parameter name.
I'm not really sure that I like the design of this patch in any way. But leaving that aside, trace_log seems like a poor choice of name, because it's got two words telling you what kind of thing we are doing (tracing, logging) and zero words describing the nature of the thing being traced or logged (the wire protocol communication with the client). A tracing facility for the planner, or the executor, or any other part of the system would have an equally good claim on the same name. That can't be right. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
