Hi, On 2019-02-27 15:34:07 +0900, Michael Paquier wrote: > On Tue, Feb 26, 2019 at 09:42:38PM -0800, Andres Freund wrote: > > I'm not so sure that's the architecturally correct fix however. Is it > > actually guaranteed, given expanded tuples, toasting, etc, that there's > > no other memory leak here? I wonder if we shouldn't work twoards using a > > short lived memory context here. Note how e.g. printtup() uses a short > > lived context for its work. > > Perhaps. I got to wonder if this change would not impact code using > their own DestReceiver, resulting in similar leaks when they insert > tuples on-the-fly.
Im not sure I understand. How can adding a memory context + reset to ctas and matview receivers negatively impact other dest receivers? > I was playing a bit with some refactoring of relation creation for > CTAS in the scope of temporary matviews, and noticed this issue on the > CF list, so that was a bit annoying, and issues like that tend to be > easily forgotten.. It's been 10 days since the report, nobody pinged, and obviously I'm working on pluggable storage, so ... Greetings, Andres Freund