On Thu, Feb 28, 2019 at 7:24 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > The flaw in my thinking was treating extension too similarly too > > finding an existing block. With your patch clearing the local map in > > the correct place, it seems the call at hio.c:682 is now superfluous? > > What if get some valid block from the first call to > GetPageWithFreeSpace via local map which has required space? I think > in that case we will need the call at hio.c:682. Am I missing > something?
Are you referring to the call at line 393? Then the map will be cleared on line 507 before we return that buffer. -- John Naylor https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
