On 2/27/19 7:54 PM, Michael Paquier wrote: > On Wed, Feb 27, 2019 at 07:45:11PM -0500, Joe Conway wrote: >> It seems to me that OpenTransientFile() is more appropriate. Patch done >> that way attached. > > Works for me, thanks for sending a patch! While on it, could you > clean up the comment on top of get_controlfile()? "char" is mentioned > instead of "const char" for DataDir which is incorrect. I would > remove the complete set of arguments from the description and just > keep the routine name.
Sure, will do. What are your thoughts on backpatching? This seems unlikely to be a practical concern in the field, so my inclination is a master only fix. Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development
signature.asc
Description: OpenPGP digital signature
