Thanks for the review.
On 2019/03/07 21:35, Etsuro Fujita wrote:
> The patch looks good to me, but one thing I'm wondering is: as suggested
> by David, it would be better to rephrase this mention in the UPDATE
> reference page, in a single commit:
>
> "Currently, rows cannot be moved from a partition that is a foreign table
> to some other partition, but they can be moved into a foreign table if the
> foreign data wrapper supports it."
>
> I don't think it needs to be completely rephrased; it's enough for me to
> rewrite it to something like this:
>
> "Currently, rows cannot be moved from a foreign-table partition to some
> other partition, but they can be moved into a foreign-table partition if
> the foreign data wrapper supports tuple routing."
>
> And to make maintenance work easy, I think it might be better to just put
> this on the limitations section of 5.10. Table Partitioning. What do you
> think about that?
I agree, so updated the patch this way.
David, can you confirm if the rewritten text reads unambiguous or perhaps
suggest a better wording?
Thanks,
Amit
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index 4c1d2f607b..1e09f87803 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -3879,6 +3879,14 @@ ALTER TABLE measurement ATTACH PARTITION
measurement_y2008m02
<listitem>
<para>
+ Currently, rows cannot be moved from a foreign-table partition to some
+ other partition, but they can be moved into a foreign-table partition if
+ the foreign data wrapper supports tuple routing.
+ </para>
+ </listitem>
+
+ <listitem>
+ <para>
<literal>BEFORE ROW</literal> triggers, if necessary, must be defined
on individual partitions, not the partitioned table.
</para>
diff --git a/doc/src/sgml/ref/update.sgml b/doc/src/sgml/ref/update.sgml
index 77430a586c..adc71ce80c 100644
--- a/doc/src/sgml/ref/update.sgml
+++ b/doc/src/sgml/ref/update.sgml
@@ -291,9 +291,9 @@ UPDATE <replaceable class="parameter">count</replaceable>
concurrent <command>UPDATE</command> or <command>DELETE</command> on the
same row may miss this row. For details see the section
<xref linkend="ddl-partitioning-declarative-limitations"/>.
- Currently, rows cannot be moved from a partition that is a
- foreign table to some other partition, but they can be moved into a foreign
- table if the foreign data wrapper supports it.
+ Currently, rows cannot be moved from a foreign-table partition to some
+ other partition, but they can be moved into a foreign-table partition if
+ the foreign data wrapper supports tuple routing.
</para>
</refsect1>
